Edible wedding favours - when to make?

I'm doing the same for my favours and i'm waiting till a few days before to do them as i don't want to risk them going stale

If you seal your bags you can make them anytime. If you are just twisting them and attaching closer to the date, especially the marshmallows. The crackers might take the humidity from the chocolate and get soggy. so I would put parchment paper in between. Chocolate might turn white if not sealed properly.

I know this may not be ideal, but I would wait to as close to the date as possible, depending on WHAT they are being stored in. I find crackers gets stale so fast, and it would suck to have those for your wedding. I suppose you could have them mostly ready (chocolate & marshmallow) and then a few days before, add the crackers.